Bug Reports · Legacy archive
V2.2+ Official Bug/Polish Thread
-
Re: V2.1+ Official Bug/Polish Thread
#161Yeaaaaaah, I am going to need to come in Saturday. Oh, and, yeaaaah, why don't you go ahead and come in Sunday too. Thaaaanks.
I noticed that too. :) -
Re: V2.1+ Official Bug/Polish Thread
#162I am back with a vengeance!
Have anyone but me noticed that you can sort most categories by "highest rated", but for some reason it doesn't work with "Articles" and "Dungeons"?
Have anyone noticed that the sorting is imperfect? I mean... When you sort by score, the actual number of votes is irrelevant. So that if one sub has 15x5 sword, it might show at the bottom of a list with several 1x5 swords... (Again I only tested this using the "Highest rated" sort filter.
Strolen: If I may be so bold, may I advise you to use a Sort(string key, string option1, string option2, string option3) method? That way the sorting is consistent and you do not have to implement it a thousand times. A call to Sort(x, x, x) is enough.
(I assume you don't have one, since the articles and dungeons behave differently than the others).
;) -
Re: V2.1+ Official Bug/Polish Thread
#163The sorting is done through a function that dynamically puts together a query. Since every page uses the same code I am not sure why only those two don't sort but I will try and find out.
And, no, you were not bold. This is bold
/**
* Function: cat_list
*
* Performs a search of the lockmor database, gathering nodes
* listed from a subcategory
*
* Parameters:
*
* id - id of the category to search
* order - what sort order to use
* dir - ASC or DESC
*
* Globals:
* db - database extensions
* per_page - amount to return
* start - the starting id to start from
*
* Returns:
*
* Array of submissions sorted by inputted variables
*/
function cat_list($id = "", $id2 = "", $order)
{
global $db1, $per_page, $start, $dir, $backend_username, $backend_table, $backend_id;
if ($order == "")
{
$order = "title";
}
elseif ($order == "rating")
{
$order = "ratings / votes";
}
elseif ($order == "random")
{
$order = "rand()";
}
if (is_numeric($id))
{
$id = 'a.parent1_id =' . $id . ' AND ';
}
else
{
$id = ""; //including if it = "all" which we do pass
}
if (is_numeric($id2))
{
$id2 = 'a.parent2_id =' . $id2 . ' AND ';
}
else
{
$id2 = ""; //including if it = "all" which we do pass
}
return $db1->get_results("
SELECT a.title,a.summary,a.author_id,a.date_submitted,a.content_id, a.idea_scroll,
a.type_id,a.parent1_id,a.parent2_id,a.scroll_count,
a.comment_count,a.hits,(a.ratings/a.votes) AS rating,
b.$backend_username as username,
c.cat_title
FROM
lockmor_content AS a,
$backend_table AS b,
lockmor_categories AS c
WHERE $id $id2
a.author_id = b.$backend_id
AND ((a.condition = '1') OR (a.condition = '3'))
AND ((a.parent1_id = c.cat_id) OR (a.parent2_id = c.cat_id))
GROUP BY a.content_id ORDER BY $order $dir LIMIT $start, $per_page");
} -
Re: V2.1+ Official Bug/Polish Thread
#164On the FlashChat, if you're working out of a tab in FF and then you close just that tab, you don't log out. If there was some way for the thing to realize that you were no longer there or what not, that'd be cool. I'm pretty sure this is what led to a recent, breach of kindness between me and AG.
It's pretty far down on the list of things that I'd personally like to see done, and as it is is just a minor inconvenience. But it's also what leaves the chat link saying there's 1 person in it for hours on end, and then when someone else pops in, they pop out. :) -
Re: V2.1+ Official Bug/Polish Thread
#165Yep. He seemed logged in and I spoke to him for a few minutes, a monologue from my part actually, and *plop* he departed.
Strange.
Usually they disappear the minute you log in if they logged out the wrong way. -
Re: V2.1+ Official Bug/Polish Thread
#166Ahh. I see what you are saying but FlashChat is a third party program so I have no control over it's actions.
When you close the tab, do you actually close the FlashChat session or do you just close the window. If you don't close the FlashChat, even if you are in a normal browser, how would it know to log out? -
Re: V2.1+ Official Bug/Polish Thread
#167I bet there are onClose events triggered in IE and the other browsers that could trigger a logoff. However: That is an issue for the developers. -
Re: V2.1+ Official Bug/Polish Thread
#168
I am back with a vengeance!
Have anyone but me noticed that you can sort most categories by "highest rated", but for some reason it doesn't work with "Articles" and "Dungeons"?
Have anyone noticed that the sorting is imperfect? I mean... When you sort by score, the actual number of votes is irrelevant. So that if one sub has 15x5 sword, it might show at the bottom of a list with several 1x5 swords... (Again I only tested this using the "Highest rated" sort filter.
Strolen: If I may be so bold, may I advise you to use a Sort(string key, string option1, string option2, string option3) method? That way the sorting is consistent and you do not have to implement it a thousand times. A call to Sort(x, x, x) is enough.
(I assume you don't have one, since the articles and dungeons behave differently than the others).
;)
Fixed the Articles and Dungeons. Those categories were created after the rest of them were working and they were missing a top_category variable that is required in the link. I have an elseif statement that is hardcoded for each category that adds that which I missed when we created those categories. They all use the same functions but these two were missing that argument.
Works now. :)
Also fixed the sorting so it sorts by rating and # votes now. -
Re: V2.1+ Official Bug/Polish Thread
#169
As reminded again in http://www.strolen.com/content.php?node=429, the first comments and scroll comments do not contain the +/- XP thingy.
Fixed -
Re: V2.1+ Official Bug/Polish Thread
#170The shout box on the main site has the text box to say stuff, but the one on the forum side doesn't have it anymore, and I know it did before the server downage. -
Re: V2.1+ Official Bug/Polish Thread
#171I had an idea.
I have a few submissions that I am adding to on a fairly regular basis.
Examples:
http://www.strolen.com/content.php?node=3265
http://www.strolen.com/content.php?node=1894
http://www.strolen.com/content.php?node=2976
I think it would be kinda spiffy if there was some sort of tag we could select in the submission section that would basically highlight said submission at our respective home pages. The favorites section would technically work, but it is limited to 3 choices, and I rarely use it. Just an idea I had.
*****
Second bit.
If you put an apostrophe in a title, you can't link back to said title just by using brackets, it keeps adding a / in front of the apostrophe. It is only a problem for me since I keep having to use the submission id with the [id | text ] system to get links back to K'ton stuff. -
Re: V2.1+ Official Bug/Polish Thread
#172Are you limited to only 3 favorites? If so, that might be a bug because I don't think I imposed a limitation.
As far as the home page link/flag thing, let me throw this at you. I have based a great deal of the site on the structure of www.everything2.com, including the home page. Check out this random example of a homepage on their site: http://www.everything2.com/?node_id=541199 and many others that are on the frontpage have other examples. I just nabbed one.
The homepage area does links just like the rest of the site so you can make lists, rants, raves, lists, etc., to your heart's content. That is where I suggest you can put the stuff you are working on...
The apostrophe is the bain of code. It is goofy in mysql, it can crash the code, and is a general pain in the but to encode and decode. I will put that on polish portion to take a look at when I want a puzzle, but the way you are linking it is the way it was made to handle that problem.
-
Re: V2.1+ Official Bug/Polish Thread
#173rechecked the favorites section and the 3 limitation seems to have gone away! Yay!
And I always knew apostrophes (those apostate catastropies!) were evil. -
Re: V2.1+ Official Bug/Polish Thread
#174A host of demons has spread in the Citadel, arousing a few problems in the process.
The 'Buzurivambavas' actually belong to CP.
Bonus display bug: in the Demons Codex (and only in it), Cheka is now the co-author to everything. -
Re: V2.1+ Official Bug/Polish Thread
#175Badda bing. -
Re: V2.2+ Official Bug/Polish Thread
#176We still have no entry field/shout button on the forum side shout box. I miss that. And the shout button Citadel side is nothing but a blank button (doesn't matter, just saying.) Also, is there some way to have a "who's in chat" thing? Or possibly like a switch you turn on to show you're in chat?
Also, I just noticed. Normally, when people shout, their name is a link to thier profile. When you said something about destroying search, Strolen, yours wasn't. Was there an actual reason, or is something broken? -
Re: V2.2+ Official Bug/Polish Thread
#177I don't know if you're still in the middle of tweaking it or not, but every time I try using the forum side shout button, I get an error that says my session timed out while I was posting. It still works fine Citadel side.
I'm really not trying to be obnoxious. :wink: -
Re: V2.2+ Official Bug/Polish Thread
#178Also on the shoutbox. Both forum and Citadel side, your name Strolen (and as far as I can tell, only your name) doesn't show up as a link to your profile when you say something. Don't know if you meant it like that, but I thought you should know just the same.
Oh and, as of 05:27:28 PM Eastern US, I still don't have those boxes/buttons for the shoutbox forumside. Now, I hear people talking about them not being able to post in it, but I'm still without it, and feeling a little left out of everyone elses problems. -
Re: V2.2+ Official Bug/Polish Thread
#179I had the shout button for a bit, but then it went away. Also, every time I try to delete a shout, I get an error that says session verification failed, try logging out then logging back in. -
Re: V2.2+ Official Bug/Polish Thread
#180I redid the theme from a fresh copy and it seems to be working. It added an extra user thingy at the bottom too that is a little interesting too. -
Re: V2.2+ Official Bug/Polish Thread
#181Fixing the shout box also fixed not being able to delete shouts. :up: -
Re: V2.2+ Official Bug/Polish Thread
#182So, I am a snoop, and I want my snoop tools!
Is there a way of adding main site subs to the list of user list topics? I mean, when I click on the logged on user list, I get a list of what people are doing right now. Unless they are on the main site that is.
Could we get a way to see what they are doing on the main site? -
Re: V2.2+ Official Bug/Polish Thread
#183Beware the snoopers! :)
The In Chat feature is very nice. Finally will I know who is inside! One thing only: write the chatter's names under the chat link, not under another line. Looks kinda out of place. Or put another line below them. Either way, I tend to confuse the person/people chatting with Users Online. -
Re: V2.2+ Official Bug/Polish Thread
#184AG: HOW DO YOU LIKE THEM APPLES??? BOOOYAAAAH. (fun hack so am excited)
manfred: It is consistant with the rest of the formatting of that menu. You will get used to it :_ -
Re: V2.2+ Official Bug/Polish Thread
#185Well, you could add a line on the bottom, but I can survive without it.
But now I finally understand AG's voyer-ish tendencies... it's actually pretty cool to see what are people viewing. Looking at my stuff, too, bwahaha! :)
Some of the posts are not linked (imagine because of the form of the link or whatever), but we have always the sub's name, so it works good enough. Neat hack indeed. -
Re: V2.2+ Official Bug/Polish Thread
#186The unlinked will disappear through attrition. First try had them unlinked so they are leftovers. -
Re: V2.2+ Official Bug/Polish Thread
#187Oops, had to undo it for a bit. The variable that the forum uses conflicts with one I use to add/edit comments and such so I have to change all my variables for this to work.
Will get it up tonight. -
Re: V2.1+ Official Bug/Polish Thread
#188
Noticed in the Bard submission, there is a problem with creating a http link (outside of the Citadel).
Somewhere along the path, quotes are added to the link in the anchor tag. So, if there are no quotes, it will produce a normal link with quotes. But if there _are_ quotes already, another ones will be added - breaking the resulting link.
So depending on how the link is posted, it may work, or may not.
Also noticed while posting and editing a new sub: it seems that with each edit, another set of quotes is added. So the HTML link may or may not work depending on how many edits were performed on it. -
Re: V2.2+ Official Bug/Polish Thread
#189I love it! I love it!
Thank you Strolen! -
Re: V2.2+ Official Bug/Polish Thread
#190See, sometimes dreams do come true.
Hope you didn't lose out on $1 million because of me stealing a dream slot though. -
Re: V2.2+ Official Bug/Polish Thread
#191You can now convert a comment to a scroll and vice versa when you edit it. -
Re: V2.2+ Official Bug/Polish Thread
#192Today you can view dungeons, articles, and so on. You can sort and order using criterias such as "most hits", etc. But when you click on an author's name and choose to see only him, you cannot do the same. So, if I clicked "Ancient Gamer" and chose "Dungeons", that would list ALL dungeons and not only my dungeons.
It would be kind of neat if it was possible to limit a category search to only one author! -
Re: V2.2+ Official Bug/Polish Thread
#193The user name links in the main site shoutbox (not the forum version) now contains mailto links. Is this your intention? -
Re: V2.2+ Official Bug/Polish Thread
#194Weird... it's only true for some users, but not for others. AG and Shadow have the problem, not me or Cheka. Sounds like a bug! -
Re: V2.2+ Official Bug/Polish Thread
#195Probably a browser conflict bug or something... Do you use dependent programming languages like VBScript or something? Ajax could be the problem too. -
Re: V2.2+ Official Bug/Polish Thread
#196I have found a bug that this creates:
When someone stand inert on the main site or the forum page, the shout_xml is continually updated, as we discussed above. Problem is that it is impossible for snoops like me to see how long since they were active... Are they really there, or did they go AFK 25 minutes ago?
Like manfred right now... He sure seems active, but then again, he has seemed active the entire day. -
Re: V2.2+ Official Bug/Polish Thread
#197Hard to say, since I had the occasional hour-long break in activity, and later returned.
Snoops want to know! Heheheh. -
Re: V2.2+ Official Bug/Polish Thread
#198Polish, minor; noticed in the Horse Brass submission:
after turning a few comments into scroll comments, I've noticed the totals for comments and scroll items didn't update for the sub. Guess it will be updated at your regular update sweep (around midnight or what), so not a big issue. -
Re: V2.2+ Official Bug/Polish Thread
#199Darnit, I thought it was working doing those additions and subtractions. I must have missed something then, thanks. -
Re: V2.2+ Official Bug/Polish Thread
#200The refreshing of the chat won't update your online status, all it does is suck in a quick database call, it doesn't do all the session tracking stuff so it shouldn't be a big deal to leave it open...just wasted bandwidth and an annoying tower of comments.