promotion check and submission count

#1

This is sth I noticed a while ago and since it automatically fixed itself the next day, I didn't report it. However, today I'm seeing it again. Basically, the code for checking *total submission count (and subsequently whether people have a level up) seems to me to be stuffing up periodically. For example, currently I've got 20 normal submissions (incl. stubs) and various In Work pieces and heaps of XP pts to get myself to Level 8. Technically, this means I should be at level 6, which is where I am normally. Today, I logged in and suddenly, I'm at Level 7 and it lists 21 submissions under my profile. However, I have done nothing that should increase my submission count. I have posted nothing new, not even a new stub or new In Work (whether Hidden or Public). The only thing I could think of is that it is doublecounting my co-authored subs (currently I've only got 1, a Wiki, you know the one I PMed you to fix the formatting) as the Co-authored sub link disappeared from my profile when I moved the Wiki from In Work to Normal sub and today the Co-authored sub has appeared again in my profile. On a previous occasion, I also got promoted by error to Level 7 because it was counting all of my Public In Work subs (I think at that point in time, I had 16 normal subs and exactly 5 pieces in In Work Public and it said I have 21 submissions) but the next day I logged in, the code fixed itself and I'm back to Level 6. Not a big issue really and it doesn't annoy me personally but since it seems to be a re-occurring issue, just thought I should point it out that possibly the coding is somehow inconsistent b/w different parts of the site that do the same thing (see asterick bit below).

*The wrong submission count I'm referring to is the total submission count in the textbox on my personal profile that lists personal level, XP and total submission count. Also, note that the total submission count given on the same page that is included in the text box that contains email notification settings IS correct.

Re: promotion check and submission count

#2

Well, I redid the counting scripts that are copied off of the overnight level check. I added a co-authored sub number under all the main areas to show where that extra sub comes from. Co-authored subs count towards your post count and leveling.

So you have 20 personal submission and 1 co-authored if the numbers are correct.

I am trying to make that author page an easier representation of what you would expect so if it isn't working they way you think or it is too complicated...I want to fix that for sure. I often find myself too close to the data to make it readable in an easy to grasp way so if you have formatting or counting suggestions on how it is done, I would love to hear them!

If it still isn't counting the way you think, continue to hit me with a hammer as it sometimes takes me a couple tries to get "get it". Thanks for posting all these things you are finding though! Every question I have to answer gets me a tiny bit closer to where we need to be!

Re: promotion check and submission count

#3

Actually, I have 19 personal subs and 1 co-authored one so I should have a total of 20 subs. That's why I think the counting script for levelling up is somehow double-counting co-authored subs. Also, the way you throw up the additional link to co-authored subs in the box containing email notification settings is definitely creating a double-count for me. The Legendary Utility Item Wiki is being counted twice, once as an Item sub and then again as a Co-authored sub.

Re: promotion check and submission count

#4

I did a more in-depth investigation into how the current script is counting co-authored subs by looking into the author profiles of Muro, Val and MJS who also got promoted recently. It appears to me that the script is not double-counting all co-authored subs as I initially thought might be the case. As a result, I speculate that the reason the script is only doublecounting for me is that the same coding logic hasn't been applied for Wikis. More specifically, it seems to me that the current coding logic is that a sub is counted as an individual sub if you are the only author associated with it or in the case of a co-authored sub, if you are the main author (basically the first author name associated with the sub) and everything else is counted as a co-authored sub. I derive at this through Muro's profile where the 30 Halfling Gifts is listed as his individual sub (where he's first author) in the box containing email settings whereas the 30 Orcish Gifts (where he is NOT first author) is listed as a co-authored sub. If the same logic applies to my case, then on my profile it should list a total of 20 individual subs that go into separate theme categories and 0 co-authored subs for me as I am the first author for the Wiki.

Re: promotion check and submission count

#5

Why am I always the butt of all these examples? :lol:

Collaborations screwy, sub counts miscounted, improperly functioning Ajax(?!)

Just kidding, Moonlake. I have been wondering about those sub counts myself. I moved a private inwork into public inwork the other day, and it took a sub away in the count. Which makes sense actually. Later i posted a sub, went up 2, then Scras started an in-work, which i signed up for, and the sub count jumped again. Then MysticMoon added me to an in-work sub, and the count jumped again, but this time by like 3-4. Then it jumped up again.

I somehow went to 107 from 100, by
1. in-work move from private to public
2. releasing 1 submission live
3. being co-author, but NOT main author on 2 in-works. Its a mystery wrapped inside an enigma, I tell ya. Or, its what you just said.

Re: promotion check and submission count

#6

109 now actually :shock:

I think that dastardly practice of moving in-works around is somehow involved. Either that or Strolen really likes me.

Re: promotion check and submission count

#7

Wow, seems like we are really drawing out all the bugs in the submission count. I actually thought any subs that are in works (whether private or public) are not part of the submission count. But like I mentioned before, there was this incidence where I posted 1 new sub, making my total sub count 16 and earning myself a level-up from level 5 to 6, and then found I actually got promoted straight to level 7. I looked at my author profile and the only place I could find those mysterious 5 subs is in my In Work-Public folder. And even more mysterious, the code righted itself the next day w/o me reporting anything i.e. my sub count went down to 16 from 21.

Re: promotion check and submission count

#8

I'm at 114 now. Its metastasizing!

Re: promotion check and submission count

#9

This is what happens with feature creep. :)

All of what you said makes sense in a nonsensical way. I will master the overnight reset count and the slowly creep through the many other scattered bits and pieces that control sub counts. That is one of the problems. When I first started, I simply kept a running number in your author status like XP. Incremented and decremented as you inputted something. Then we added all the different in work, privates, etc...then we added stubs which I am not sure if I count or not, then we added collaborator stuff which is a BEAST of confusion to check, count, track and that takes another table AND a comma separated list in your author information and then we did wikis which I don't even know how I made that word. At some point I moved (because of the difficulties in keeping the author stat up to date) to a dynamic count each time you looked at the numbers which is obviously missing some vital piece.

So there is a lot of small pieces of code doing lots of stuff that I once understood and must restudy then determine how we mean for it all to come together. So I am very happy you noticed these issues. I can fix it, but will concentrate on the author page first I think. Then at least you can help me look.

Will mess with it all as soon as I get a chance!

Profile not displaying the correct number of submissions?

#10

Under my profile it says I have 43 subs, however when view my "all submissions area and clicking on certain areas not all of the subs are showing:

What it shows I have for sub #'s:

Plots (2 )
Items (8 )
NPCs (12 )
Lifeforms (6 )
Locations (11 )
Articles (15 )
Society/ Organizations (2 )

What is displays when clicked on:

Plots (1)
Items (3 )
NPCs (10 )
Lifeforms (6 )
Locations (6 )
Articles (12 )
Society/ Organizations (1 )

Not sure what the error is, but it's odd none the less.

Re: Profile not displaying the correct number of submissions?

#11

I also noticed this aspect and I thought this arises because the first set of numbers is based on everything you've ever written of a particular category (irrespective of viewing options i.e. In-work Public, In-work Private, Normal etc.) whereas those actually displayed include only Normal subs and Stubs. At least, this seems to hold up for me personally.

In general, however, there is currently sth off with the total submission count displayed on author profiles. For details, see the thread directly below this one (started by me). I think Strolen is currently looking through the code to see how he wants to reprogram things to make things more intuitive and internally consistent on the author profile.

Re: promotion check and submission count

#12

OK. Double checking all these queries today.

Author Page--
Category count: I changed it to show only "Normal" submissions. Any of the special cases won't show up. I have another flag that allows it to be viewable to others that I was using so changed that.
Total Sub Count: Did the same update except that one also includes the Collaboration number of posts you can see under the category counts.

Took a second look at the collab portion as well. Looks like I was doing a straight select so updated that to distinct so if it is a wiki collaboration (which does count) then it will only select a single instance of a wiki update vs. every update that might have polluted the collab database.

Did the same to the daily cron job so, if nothing else, both these numbers should be more accurate. They should match each other anyway so if the author count is still messed up, then the cron job will be equally wrong. At least that way it is easier to troubleshoot.

Bottom line, I took out any ambiguity of how visible content was tracked and base the count directly on the "Normal" condition of a submission.

Re: promotion check and submission count

#13

Oh, this totally ignores stubs....I think I am ok with that.

Re: promotion check and submission count

#14

There's still something weird with collaborative submissions that is polluting the total submission count. Under the new system in which only normal submissions are counted, then I'm supposed to have only 17 submissions in total. However, due to collaborative subs, the number on my author profile has been pushed up to 20, which is wrong. In particular:
1. I have 1 Wiki that has already been counted in category count (because I'm first author) so I'm thinking potentially the current way of coding still doublecounts all the collaborative subs in which someone is the first author.
2. I have another collaborative sub that is currently in In Work-Public, this shouldn't be counted at all.

Re: promotion check and submission count

#15

That could be one. The collaborative sub check doesn't have a check to see if the sub is "Normal." I don't have anything in place for that scenerio either. Wow, that is a kicker.

Right now I have the main sub with the collaborative folks all in one field separated by commas. I take the field every time the sub is edited and make sure it is in another table that only tracks the sub ID and the collab author ID.

I might have to make a new column on the second one to track which collab authors I can count. Might be the easiest....

Re: promotion check and submission count

#16

Hmmm... after two edits on a collaborative sub between me and MysticMoon, the number of collaborative subs under my author profile went up from 3 to 8.