Administrators · Legacy archive

Manfred's little polishing list

Started by manfred Dec 9, 2007 36 posts Locked

  1. Manfred's little polishing list

    #1
    In the name of Mathom, who as ever guards over my time in this dimension, another pet project is started.

    This here is the beginning of a list of various little changes performed in the very bowels of the Citadel, in, *whisper:*  "The Code"! I will be tinkering with various little things, that often tend to stay behind, and annoy, which is mostly the polishing stuff, and minor bugs. I promise to choose my targets completely arbitrarily, and without any pre-determined time schedule whatsoever. You may choose to give me hints as to what to hit next, and I promise to vaguely consider them. Small things are more likely to be done as the big things.

    The list will be updated.

    ---

    random.php - fixed a little code discrepancy
    node.php - 'Updated' comments will now update also the submission itself... which means they will be visible in Newest 20 Comments, etc.
    roleplay_post.php - added a few omitted words
    content.php - made sure Stubs can be Suggested as well
    theme/castle/node_format.tpl.php - Stubs have the Remove link when in a Codex
  2. Re: Manfred's little polishing list

    #2
    I will be doing a little messing this weekend so let me know if you make any more changes. Post a reply so I get an email about an update.
  3. Re: Manfred's little polishing list

    #3
    No changes being done right now... last thing I was playing with (but left no lasting changes) were node.php and node.tpl.php, which valiantly resist any of my modifications to achieve the full coauthorship thingy. Darn.

    I'll let you know when I start another experiment. ;)
  4. Re: Manfred's little polishing list

    #4
    I am going to work a bit on the admin page. Get the quest working correctly and add some other admin functionality to keep me from having to go into the database all the time for fixes.
  5. Re: Manfred's little polishing list

    #5
    PS.

    Upgraded the server to Apache 2.0. Too chicken to go all the way to 2.2 in one leap. Did a few http.conf tweaks to reduce load so will see what happens with new server software. PHP was upgraded to latest and EAccelerator is a package install with the server. All that together...I hope it stabilizes.
  6. Re: Manfred's little polishing list

    #6
    Can you add a HTML help link adjacent to a submission box when you are editing a post? It would be handy to have it "right there" instead of having to open up a new window, then find and click it.
  7. Re: Manfred's little polishing list

    #7
    There was a HTML help on the top of the right column when inputting/editting a submission. I moved the expandable link to the bottom though so it will be next to the submission when you are inputting it for better convenience. This one can be open when you are editing and has been there, just at the top of the column instead of the bottom.
  8. Re: Manfred's little polishing list

    #8
    Add/Edit a Submission 
     
    Submission Title:
      Must be unique and cannot be a username. Use proper case and only ' (apostrophes) or - (dashes) are allowed. 
    Select Influence
    Campaign
    Character Sheet
    Extras
    Extras-Horde
    Major
    Minor
    Mythic/ Historical
    Scenario Based
    « Show Influence Definitions 
    Campaign These are major non player characters that are important to the campaign being run, their actions influence the campaign. In fact, if they were a different person, the campaign would be different.
    Character Sheet This category is for PCs involved in forum RP
    Extras These are members of the background that fill the world behind the player characters. They are needed to give versimilitude and life to the game world the players are passing through. Any Extra character would be either a typical character or a nearly typical (just different to stand out slightly) character. The players might have a line or two of dialog with them. If the extra is interesting, there might be more interaction with them, and the extra becomes the springboard for minor subplots in the game.
    Extras-Horde These are groups where a single character sheet and description defines (nearly) every member of the group. This would be for dockside bandits, Ninjas, pitchfork and torch wielding peasants, BlackMoor Barbarians Riders, or some other loose group of near identical people. Hordes are almost always antagonistic.
    Major These are characters that are of major importance in this chapter of the characters' existance. They are either villians (master minds, Leaders, major minion), major allies (supporting characters), or Color characters (The Archmage, The Leader of the Living Trees, ). Most of the "name characters" in the Lord of the Rings are Major ones.
    Minor These are characters that are of minor importance in this chapter of the characters' existance. They are either minor villians (important minions, lieutenants, monsters of some note), minor allies (supporting characters), or Color characters (the local headman, a healer, soothsayer, the troll beneith the bridge) The line between Minor Color Characters and Extras is a little fuzzy. It all depends upon the character's presentation to the players.
    Mythic/ Historical These are characters the players will never meet, but their existance has impacted the world. Even if they were not real (or were not quite what the legends pain them), they have made an impact upon their world. Think King Arthur, Merlin, Alexander the Great, Cesar, Noah, and more.
    Scenario Based These are characters are used to drive a single scenario (or a few tightly linked ones). Once those scenarios are resolved, the character is no longer really imporant to the campaign.

     
    Select Focus
    Agricultural
    Artistic/Performance
    Combative
    Criminal/Espionage
    Domestic/ Craft
    Knowledge/Lore
    Mercantile
    Mystical
    Natural
    Political
    Religious
    Technical
    Travelers
    « Show Focus Definitions 
    Agricultural This is a character who concentrates upon growing food and organic resources. The primary argicultural is the farmer, but it includes ranchers, field hands, moisture farmers, and harvesters. This is not a very heroic orientation, but some times your NPC is a farmer.
    Artistic/Performance These is a character who concentrates on the creative area of living, both performance arts, writing, and producing artistic things. These are groups of dancers, musicians, writers, bards, actors, and sculpters. It also includes collectors, critics, and patrons of the arts.
    Combative This is a character who concentrates upon warfare and personal combat. Soldiers, Mercenaries, Sargents, Tacticians, Generals, Military supply/ logistics, and so on.
    Criminal/Espionage This is a character who focuses upon stealth, infiltration, and/ or the taking of goods and information. This is for criminals, spys, assassins, and those who combat them, detectives, intelligence officers, and police.
    Domestic/ Craft This is a character who focuses upon performing domestic task or other trade crafts. This includes servants, wine makers, and senchals.
    Knowledge/Lore This is a character who focuses upon wisdom and learning. They are a curious and investigative type. They gather knowledge for themselves and sometimes teach others.
    Mercantile This is a character who focuses upon trade, commerace, business of all types, and money. Salesmen, merchants, traders, brokers, and investors are of a mercantile focus.
    Mystical This is a character who focuses upon thaumaturgy (magics of all types), powers of the mind, and the cosmic forces of the universe, including deities. Many of a mystical orrientation are also known for theurgical knowledge - wisdom and understanding of the universe.
    Natural This is a character who focuses upon the skills useful for life in the wilds. This includes, and is not limited to, ability to move through the environment, ability to find food, ability to find water, ability to find shelter, and an understanding of flora and fauna.
    Political This is a character who focuses upon political power, the process of government, and the leading of people. Suitable for politicians, ambassadors, courtiers, councilors, first speakers, leaders, kings, princes, dukes, and others who control the course of cities, states, and nations.
    Religious This is a character who focuses upon the theurgical, knowledge and wisdom of the universe and deities. Most of the religious orrientation work with their community, doing the divine will. This is suitable for Shamans, WitchDoctors, Priests, Monks, and Clerics of all persusasions. Many of a religious orrientation are also known for thaumaturgical knowledge and power (wonder working, magic, miracles).
    Technical This is a character who lives for the functional, mechanical, and technical. They are craftsmen, the makers of things, stone smiths, hackers, radio operators, warp engineers, trapsmen, motorheads, and others who live for machines and technology.
    Travelers This is a character who lives for travelling by some means. Sailors, Pilots, Navigators, Sumarriners, Dragon Riders, Pony Express Riders, Drivers, and Charioteers, are all examples of Travelers.

     
    Freetext
      « Freetext Defined 
    Very Important if you intend on linking some of your submissions. By using the same Freetext word in each of your submissions you will allow them to be brought together without explicity linking them. If you are starting a world, we suggest using the name of your world here. You may use other submission's Freetext if you want to relate your submission to theirs. It will show up in the right menu of your post as a link to other submissions with the same Freetext.Separate each freetext with a comma! 
     
      Normal Submission
    Codex
    Scroll
    Both Codex and Scroll  « Codex and Scroll Defined 
    Codex
    Changes your submission from a stand alone idea into a site wide collaborative topic to be used as a stepping stone for more ideas or a collection area for associated submissions. If you check this then other people (and you) can add full submissions to be listed with this Codex in a gathering of related submissions. Remember, if you check this then this is the Main Codex Description, not necessarily an actual submission. To add a submission to a Codex go to that Main Codex and add it through the suggestion box at the bottom. Use this to introduce and describe what the Codex will be about. If you are not sure you want this, take a look at some current Codices
    Scroll
    Commented ideas that go with the theme of the Scroll. It still retains all comment and voting abilities, but the focus of the Scroll is the adding of other ideas to make a long list of associated ideas and thoughts. The Scroll remains seperate from comments so you can keep the creative flow going. If you are not sure you want this, take a look at some current Scrolls (opens in new window) to see if this is your intention.

    Note: You can choose Codex or Scroll, or you can have them both available in the same submission. 
     
      Open
    Locked  « Open and Locked Defined 
    Open
    Normal submission. Others allowed to add suggestions.
    Locked
    Author is the only one allowed to add suggestions.
    (Mostly useable for a Codex or Idea List that you want to develop on your own or if you have a series of submissions that you don't want others to add anything to) 
     
    Submission Options
    Normal Submission In Work (hidden) In Work (request advice) In Work (viewable) Stub Requires Edit Deleted Challenged Awaiting Approval Kiss of Death  « Submission Options Defined 
    Normal Submission = Well, a normal submission. Shows up immediately for all to view and comment on.
    In Work (hidden) = You are not done with it and is hidden from everybody. Viewable only by you from your Profile Page.
    In Work (request advice) = If you have an already FINISHED submission that you want a review of before you submit it to the wolves, then use this. It is NOT for asking for help with an idea that you haven't fully thought through. If you need help building an idea please use the forum. You are allowed one of these at a time. Choosing this updates this, and only this submission to this status. If you previously had another submission with this flag it will be changed automatcially to In Work (viewable). Viewable from your Profile Page and the Advice Requested page, this will bring your submission to the attention of site visitors who will do their best to help you work through your questions. Only viewable through "Advice Requested" link and in Profile, not in the main parts of the site.
    In Work (viewable) = Allows anybody on the site to view and comment on these submissions through the In Work link. Only viewable through In Work link and in Profile, not in the main parts of the site.
    Stub (special hidden) = Some short text you wish to reuse or an idea that you intend to expand on but may be necessary to have with your other submissions. Only viewable by links or through the author's control panel. No voting/HoH/XP etc.
    Challenged = Somebody thought it innappropriate. Still being voted on to require edit or leave it.
    Awaiting Approval = After you edit a challenged submission, set it to this and it will have to be approved by a moderator.
    Note: Not all options will be available. Depends on the submissions condition. 
     
      BBcode Translator  « BBcode Translator Defined 
    Are you copy and pasting your post from a forum that uses BBcode? This should take your basic BBcode (only , , and for now) and translate it into HTML goodness and retain your original formatting. 
     
    Contributors
      « Contributors Defined 
    Did you have other people that gave you significant help with your idea?
    Did a group of people develop this submission?

    If so, then give them some credit and put the contributor's ID here.
    If there are multiple authors that helped then separate each ID with a comma.
    Example: 2,87,2543,788 


    Summary
    She is The Princess of the Night Faire

     
    Main Submission Area
    Appearance
    Adjella is quiet easy to look at. She has a lovely smile, sparkling eyes, and ..............
     
    Update Note (When updating a submission you should to provide a reason why so when we view it we know what changed and can update our votes/comments appropriately.)
         

    POST AS DIFFERENT USER (which is their numbered ID)


    So where abouts would that be?
  9. Re: Manfred's little polishing list

    #9
    The right column...
  10. Re: Manfred's little polishing list

    #10

    Strolen - OK, can you see if you can edit a contrib submission now? Thanks!
    Murometz - seemed to work!


    Umm, guys, did anyone try with a non-admin account?
  11. Re: Manfred's little polishing list

    #11
    Oh, thats right, he is an admin. ;)
  12. Re: Manfred's little polishing list

    #12
    Gotcha! :p
  13. Re: Manfred's little polishing list

    #13
    Manfred, didn't you have a quick code snippet for easy collapseable text blocks? I was looking at the spoiler request and was going to slap that in and though that you had an easy bit of code for it somewhere. What I am using, while doable, I remember being uglier than what you came up with.
  14. Re: Manfred's little polishing list

    #14
    (whole code snippet sent on its way already)

    Now, updated the Quest downloads page (downloads.php), and uploaded two last Quest PDFs. Gotta keep that one around.
  15. Re: Manfred's little polishing list

    #15
    Thanks manfred!
  16. Re: Manfred's little polishing list

    #16
    I had a little trip among the warnings and error messages of late, mostly it's reporting of missing files and the like. May take a stab at them some day.


    MANY errors/warnings referring to the line 760 of ez_sql.php:

    [Sat Jan 19 00:01:30 2008] [client 77.88.26.25] PHP Warning:  You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 5 in /home/strolen/ez_sql.php on line 760
    [Sat Jan 19 00:01:37 2008] [client 77.88.26.25] PHP Warning:  Unknown column 'a.cond' in 'where clause' in /home/strolen/ez_sql.php on line 760
    [Sat Jan 19 00:02:03 2008] [client 66.249.72.42] PHP Warning:  You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'ORDER BY title ASC' at line 4 in /home/strolen/ez_sql.php on line
    [Sat Jan 19 00:02:29 2008] [client 74.6.24.48] PHP Warning:  You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AS relevance FROM lockmor_content\r\n      WHERE ( detail LIKE '%715%'  OR  title' at line 2 in /home/strolen/ez_sql.php on line 760
    [Sat Jan 19 00:03:06 2008] [client 77.88.26.25] PHP Warning:  Unknown column 'a.cond' in 'where clause' in /home/strolen/ez_sql.php on line 760
    [Sat Jan 19 00:03:19 2008] [client 77.88.26.25] PHP Warning:  You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 5 in /home/strolen/ez_sql.php on line 760
    ...
    // If there is an error then take note of it..
                            if ( $str = @mysql_error($this->dbh) )
                            {
    $is_insert = true;
                    $this->register_error($str);
    $this->show_errors ? trigger_error($str,E_USER_WARNING) : null; // line 760, ???
            return false;
            }




    [Sat Jan 19 00:03:03 2008] [client 72.171.0.141] File does not exist: /home/strolen/public_html/upshrink.gif, referer: http://www.strolen.com/guild/index.php
    [Sat Jan 19 00:03:03 2008] [client 72.171.0.141] File does not exist: /home/strolen/public_html/upshrink2.gif, referer: http://www.strolen.com/guild/index.php
    [Sat Jan 19 00:03:03 2008] [client 72.171.0.141] File does not exist: /home/strolen/public_html/collapse.gif, referer: http://www.strolen.com/guild/index.php
    [Sat Jan 19 00:03:04 2008] [client 72.171.0.141] File does not exist: /home/strolen/public_html/expand.gif, referer: http://www.strolen.com/guild/index.php

    The pictures are where they should be (under guild/Themes/final_winter/images/), and yet they are requested from the main page's home directory.

    See index.template.php of the theme (or all of them).



    [Sat Jan 19 00:03:19 2008] [client 69.141.185.33] File does not exist: /home/riahawk/public_html/favicon.ico, referer: http://knighthawk.strolen.com/images/gir!.jpg
    [Sat Jan 19 00:03:19 2008] [client 69.141.185.33] File does not exist: /home/riahawk/public_html/404.shtml, referer: http://knighthawk.strolen.com/images/gir!.jpg

    Looks like an invalid name (or at least not good for this purpose). Is not linked from anywhere, can be renamed.


    [Sat Jan 19 00:06:10 2008] [client 66.249.72.42] PHP Warning:  gzuncompress() [function.gzuncompress]: data error in /home/strolen/public_html/inc/jpcache/jpcache-main.php on line 322
    ???

    [Sat Jan 19 00:19:28 2008] [client 74.6.26.213] PHP Fatal error:  Call to undefined function cat_list() in /home/strolen/public_html/content3.php on line 1371
    In development; no biggie.


    Varied file missing reports

    [Sat Jan 19 00:22:09 2008] [client 87.106.131.26] File does not exist: /home/strolen/public_html/public_includes
    [Sat Jan 19 00:34:08 2008] [client 195.117.130.181] File does not exist: /home/strolen/public_html/guild/tavern/chat
    [Sat Jan 19 00:34:09 2008] [client 195.117.130.181] File does not exist: /home/strolen/public_html/chat
    [Sat Jan 19 00:34:10 2008] [client 195.117.130.181] File does not exist: /home/strolen/public_html/guild/chat

    [Sat Jan 19 00:46:58 2008] [client 72.171.0.141] File does not exist: /home/strolen/public_html/guild/images, referer: http://www.strolen.com/guild/index.php

    [Sat Jan 19 00:46:58 2008] [client 77.88.26.25] File does not exist: /home/strolen/public_html/guild/www.mongoosepublishing.com

    [Sat Jan 19 00:47:02 2008] [client 87.230.3.98] File does not exist: /home/strolen/public_html/[Path_mGallery]


    [Sat Jan 19 00:48:18 2008] [client 89.171.55.19] script '/home/strolen/public_html/guild/tavern/inc/cmses/aedating4CMS.php' not found or unable to stat
    [Sat Jan 19 00:48:18 2008] [client 89.171.55.19] script '/home/strolen/public_html/guild/tavern/inc/cmses/aedating4CMS.php' not found or unable to stat

    Said files are an exploit according to http://www.milw0rm.com/exploits/2293 - doesn't work for us, though!


    [Sat Jan 19 01:02:17 2008] [client 38.99.44.102] File does not exist: /home/strolen/public_html/netbooks/http:

    [Sat Jan 19 01:04:28 2008] [client 66.249.72.42] File does not exist: /home/strolen/public_html/"""""http:

    [Sat Jan 19 01:33:44 2008] [client 80.84.66.3] File does not exist: /home/strolen/public_html/old/images

    [Sat Jan 19 01:44:27 2008] [client 65.112.127.248] File does not exist: /home/strolen/public_html/"
  17. Re: Manfred's little polishing list

    #17
    That ezSQL one is hard to troubleshoot. That is the database abstraction layer so every query goes through that and I have no idea where it comes from. I found a couple by the passed variables that the error held but others are just impossible to figure out. :(

    some of those a.cond are fixed already as they were mistypings by me. I just happened to know where those calls are made. Others are too generic to fiddle out.

    I looked at those graphics (upshrink and such on the forum) yesterday as a matter of fact. Reuploaded them and everything. There are 1000+ misses for each of those this month alone. That one annoys me.

    Many of the others I don't have big issues with but would be nice to get rid of them!

    Thanks manfred. Makes it easier to grab a couple and try to fix them!

  18. Re: Manfred's little polishing list

    #18
    Note to self: when I get around to coding here again, kill the node=1234&from=5678 links. They annoyed me visually long before, and bring all sorts of other annoyances along.

    See if other simple things are laying around.
  19. Re: Manfred's little polishing list

    #19
    Thank you, in advance
  20. Re: Manfred's little polishing list

    #20
    Yeah, those were going to make "soft" links like on the bottom of the everything2 page but I never implemented them.

    Won't be on 3.0
  21. Re: Manfred's little polishing list

    #21
    Aaand the hated back links are gone. Was quite simple even, just had to change the node_suggest_link function in inc/links.inc.php. Strolen organizes his libraries well.

    Better now.
  22. Re: Manfred's little polishing list

    #22
    A couple of small stuff:

    - fixed links in Citadel Explained/roleplay.php
    - added a line into Play part roleplay_play.php
    - titles of 5RD quest submissions were emboldened in downloads.php
  23. Re: Manfred's little polishing list

    #23
    To remind you, Stubs should show up in Free-Text searches

  24. Re: Manfred's little polishing list

    #24

    Fixed that email one. Another one with the database change.

    If I didn't fix them all, when there are errors like emailAddress and memberName errors the new database changed them all to a new format email_address and member_name.


    Man, this really sucks! Names shouldn't simply change like that! I'm afraid we have some more hidden deviations.

    ---

    Fixed the ever-new comments, in theme/castle/comment.tpl.php, simply changed lastLogin to last_login.

    Fixed the broken user links under Users Online. Changed inc/rtmenu2.inc.php, the DB call asked ID_MEMBER, the PHP worked with id_member... seems it didn't make problems until now.
  25. Re: Manfred's little polishing list

    #25

    To remind you, Stubs should show up in Free-Text searches


    They show up now; required was a little extension of the view.php; updated three db calls. Example.


    If we keep them that way, it would be probably useful to show their Stub status on listings in red (like Advice Requested). Reminder for that time: function node_summary in theme/castle/format.tpl.php.
  26. Re: Manfred's little polishing list

    #26
    They are case sensitive I do believe and they did change it from ID_MEMBER to id_member so that was a solid fix.

    Thanks for digging into it manfred!!
  27. Re: Manfred's little polishing list

    #27
    Fixed the ever-new comments, in theme/castle/comment.tpl.php, simply changed lastLogin to last_login.


    Fixin' the fix, don't you love those. After another intervention in the same place, and one under theme/castle/node_format.tpl.php, all the comments show their new-ness properly, even the scrolls and 'replies'.

    Better now.

    ---

    Some more lastLogin edits:
    theme/castle/comment.tpl.php
    view.php
    inc/cron.inc.php
    theme/castle/auth_comment.tpl.php
    theme/castle/auth_comment.tpl.php
    theme/classic/user.tpl.php
    theme/plain/user.tpl.php
    theme3/plain/comment.tpl.php
  28. Re: Manfred's little polishing list

    #28
    Another reminder: there is something broken in Users Online, got to look into that.

    Also remembered an oldie in "Comments by", that tended to overlook some of the comments, should look into it as well... plus there is an error:
    Warning: Unknown column 'memberName' in 'field list' in /home/strolen/ez_sql.php on line 760
  29. Re: Manfred's little polishing list

    #29
    That error will be in the page you found it, not in the ez_sql.php file. Not sure where this error is.
  30. Re: Manfred's little polishing list

    #30
    Better, some more investigating to do.

    Users Online are not so erratic anymore, but it seems they vanish pretty fast when not active. Changed some details in inc/rtmenu.inc.php, but this problem may be elsewhere.


    Comments by are now Comments by (Author) at last. More importantly, the visibility bug is killed; all caused by a trivial detail. After a comment is updated, it isn't shown on the list anymore.

    Every comment has a scroll status, which is 1 for a scroll. A freshly created standard comment has a zero for this purpose; an update rewrites it to an empty string instead. The result depends on what the code will tests for. view.php was changed to test for stuff not equal to 1... and that's it.


    Enough for today... tomorrow, we can finish off Dark Lord's comments!
  31. Re: Manfred's little polishing list

    #31
    Function in inc/lockmor.php that determines user rights, and the section dealing with the HoH. Behold the beauty finely hammered in:

          case "hoh":
            if ($level >= "3"
                && $hoh_votes > 0
                && $author_id != $author
                && $author > 0)
            {
                $is_recent = $db1->get_results("
                  SELECT content_id, date_submitted
                  FROM lockmor_content
                  WHERE content_id = $node_id
                  AND date_submitted > UNIX_TIMESTAMP() - 3*24*3600");
                if ( $is_recent)
                {
                  return FALSE;
                }
                $hoh_count = $db1->get_var("
                  SELECT count(*)
                  FROM lockmor_hoh
                  WHERE hoh_content_id = $node_id
                  AND hoh_voter = $author");
                if ($hoh_count < $level)
                {
                  return TRUE;
                } else {
                  return FALSE;
                }
            } else {
                return FALSE;
            }
            break;

    Now that we've got the place, we can of course adjust the duration in any way desired. (And yes, that should have been a constant... but I got lazy and the next version is coming on. Software development, baby.)
  32. Re: Manfred's little polishing list

    #32
    Sweet action!
  33. Re: Manfred's little polishing list

    #33
    The fact that HTML links are broken still sucks. Somebody's got to take a day off sometime and look if it can't be fixed.


    Note: take a closer look at HTMLPurifieri, it is used right at the sensitive place...
    (see /inc/htmlpurifier/)
  34. Re: Manfred's little polishing list

    #34
    Fixed anothe sql bug as referred in here. Same old memberName variable which should be member_name, but it's a good feeling.

    Let me know if you find other sql bugs.

    ---

    Also noticed the same issue in the Last Visit department of view.php, which is AGES in need of repair. Fixed for a try, please report your observations here in the next few days.

    (reminder)
    elseif ($node == "last_visit")
    {
            $time1=time();
            $lastvisit_times = 'Last Visit: '. showdate($smf_user_info['lastLogin']) .
            ' ---- Current Time: '.showdate($time1);
      $visited = $smf_user_info['lastLogin'];
            $visit_choice = getVar("visit_choice");
    ...


    Fixed the broken link, that appeared when a search with an invalid submission title was made (content.php, searching for the node).


            $node = search_node($node);              //if linked to a node that has not been created yet
            $user_search = user_search($search_term);  //see if they looked for a
  35. Re: Manfred's little polishing list

    #35
    Still looking into the error displayed, when you do an invalid search.

    The original function, bold the changes:
    function search_node($query)
    {
            global $db1;
            $query = ereg_replace("[^A-Za-z0-9]", "", $query);
      require_once('inc/fulltext.php');  //change search string into boolean
      $query = safeHTML(my_addslashes($query));
      //$fulltext_key = get_fulltext_key("lockmor_content");
          //see fulltext.php for where I matched cat_id and type_id
      $match = boolean_sql_select(boolean_inclusive_atoms($query), 'detail, title, summary, desc1');
      if($match)
      {
          $match = $match.", ";
      }

      $sql = "SELECT content_id, title, summary, type_id, parent1_id, parent2_id " // comma removed here
          //. boolean_sql_select(boolean_inclusive_atoms($query), 'detail, title, summary, desc1')."
          .$match."
          AS relevance FROM lockmor_content
          WHERE "
          .boolean_sql_where($query,'detail, title, summary, desc1')
          ."AND ((cond = '1') OR (cond = '3') OR (cond = '5'))"
          ." GROUP BY content_id HAVING relevance>0 ORDER BY relevance DESC LIMIT 0, 50";

    OK, now the problem is somewhere in that boolean_ function, which returned nothing for the queries in question. A comma being at the end of the preceding line of the sql statement, it produced the error. I worked around it, then got another error:

    Warning: Can't find FULLTEXT index matching the column list in /home/strolen/ez_sql.php on line 760 (?)

    Now that I understand even less, what is wrong, I guess I should give the repairs a break. :)
  36. Re: Manfred's little polishing list

    #36
    Just noticed, that submissions in Advice Requested are possible to favorite, HoH, challenge and nominated for Golden Sub.

    Seems like at the very least the Hoh and nominating links should be dropped there.

Administrators · All categories · Guildhall